Skip to content

BUG: Parachute lag warning when lag is 0 #2 #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2023

Conversation

MateusStano
Copy link
Member

Pull request checklist

  • Tests for the changes have been added
  • Docs have been reviewed and added / updated if needed
  • Lint (black rocketpy) has passed locally and any fixes were made
  • All tests (pytest --runslow) have passed locally

Discussion

  • Continuing from BUG: Parachute lag warning when lag is 0 #343

  • Seems like not all changes required to fix this issue were made. Probably I made some mistakes with git somewhere in the way of importing these changes from the dispersion to a new branch

Anyway, need your review again @giovaniceotto

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@MateusStano MateusStano changed the base branch from master to beta/v1.0.0 April 27, 2023 04:34
@MateusStano MateusStano self-assigned this Apr 27, 2023
@MateusStano MateusStano added this to the Release v1.0.0 milestone Apr 27, 2023
@MateusStano MateusStano added Monte Carlo Monte Carlo and related contents Bug Something isn't working Flight Flight Class related features and removed Monte Carlo Monte Carlo and related contents labels Apr 27, 2023
Copy link
Member

@giovaniceotto giovaniceotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple and effective solution, applied to both overshootable and non-overshootable parachute triggers.

@giovaniceotto
Copy link
Member

giovaniceotto commented May 8, 2023

Just noticed no tests ran for this commit. Any idea why @MateusStano?

@Gui-FernandesBR
Copy link
Member

Tests running without errors here...

@Gui-FernandesBR ➜ /workspaces/RocketPy (bug/no-chute-lag-warning) $ pytest .
=========================================================== test session starts ===========================================================
platform linux -- Python 3.10.4, pytest-7.3.1, pluggy-1.0.0
rootdir: /workspaces/RocketPy
plugins: anyio-3.6.2, cov-4.0.0
collected 381 items                                                                                                                       

tests/test_environment.py ........sss.s.ss..                                                                                        [  4%]
tests/test_environment_anaysis.py ssssss                                                                                            [  6%]
tests/test_flight.py ...............................                                                                                [ 14%]
tests/test_function.py ............................................................................................................ [ 42%]
................................................................................................................................... [ 77%]
................................................                                                                                    [ 89%]
tests/test_plots.py ..                                                                                                              [ 90%]
tests/test_rocket.py ......................                                                                                         [ 96%]
tests/test_solidmotor.py ..........                                                                                                 [ 98%]
tests/test_utilities.py ...                                                                                                         [ 99%]
tests/acceptance/test_bella_lui_rocket.py .                                                                                         [ 99%]
tests/acceptance/test_ndrt_2020_rocket.py .                                                                                         [100%]

============================================================ warnings summary =============================================================
tests/test_utilities.py::test_fin_flutter_analysis
  /workspaces/RocketPy/rocketpy/utilities.py:300: RuntimeWarning: divide by zero encountered in scalar divide
    safety_factor[i][1] = flutter_mach[i][1] / flight.MachNumber[i][1]

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
=============================================== 369 passed, 12 skipped, 1 warning in 54.15s ===============================================

@giovaniceotto giovaniceotto merged commit 95a8851 into beta/v1.0.0 May 9, 2023
@Gui-FernandesBR Gui-FernandesBR deleted the bug/no-chute-lag-warning branch May 26, 2023 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Flight Flight Class related features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants