-
-
Notifications
You must be signed in to change notification settings - Fork 194
BUG: Parachute lag warning when lag is 0 #2 #356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simple and effective solution, applied to both overshootable and non-overshootable parachute triggers.
Just noticed no tests ran for this commit. Any idea why @MateusStano? |
Tests running without errors here...
|
Pull request checklist
black rocketpy
) has passed locally and any fixes were madepytest --runslow
) have passed locallyDiscussion
Continuing from BUG: Parachute lag warning when lag is 0 #343
Seems like not all changes required to fix this issue were made. Probably I made some mistakes with git somewhere in the way of importing these changes from the dispersion to a new branch
Anyway, need your review again @giovaniceotto