Skip to content

TST: Remove Flutter Tests #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2023
Merged

Conversation

MateusStano
Copy link
Member

Pull request type

  • Code base additions (bugfix, features)
  • Code maintenance (refactoring, formatting, renaming, tests)
  • ReadMe, Docs and GitHub maintenance
  • Other (please describe):

What is the current behavior?

The flutter analysis yields inconsistent results across different computers, with the most significant variations occurring when changing operating systems. Surprisingly, even when the operating system remains the same, discrepancies still arise.

Although we are uncertain about the root cause, there may be a possible correlation with the issue described in this Stack Overflow post: https://stackoverflow.com/questions/38228088/same-python-code-same-data-different-results-on-different-machines.

@MateusStano MateusStano added the Tests Regarding Tests label May 26, 2023
@MateusStano MateusStano added this to the Release v1.0.0 milestone May 26, 2023
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@MateusStano MateusStano changed the base branch from master to beta/v1.0.0 May 26, 2023 01:59
@MateusStano MateusStano added the Bug Something isn't working label May 26, 2023
@Gui-FernandesBR
Copy link
Member

Modifying tests is a critical decision always, excluding them is just unacceptable.
However, since (1) it is not a core functional of rocketpy, and (2) it is slowing down our development, I agree with deleting the corresponding code.

It is worth mentioning that this is a temporary fix only. We should recreate tests for the flutter feature right after the v1.0.0 release.

Unfortunately, a new issue should be opened in our repo. This way we avoid "forgetting that it was a problem in the past".

@Gui-FernandesBR
Copy link
Member

PR already approved and new related issue raised.
Feel free to merge this one whenever you want @MateusStano , thanks!

@MateusStano MateusStano merged commit b104c01 into beta/v1.0.0 May 26, 2023
@Gui-FernandesBR Gui-FernandesBR deleted the enh/remove-flutter-tests branch May 26, 2023 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Tests Regarding Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants