-
-
Notifications
You must be signed in to change notification settings - Fork 194
ENH new utility functions #376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tests passing locally (windows 11, python 3.11.0), but failing on the github workflows (ubuntu); do we have another fin_flutter case here? LOL |
Nope, it is broken here too
We definitely do. I tried tightening the tolerances and it did not solve the issue too. The only way we know for now to fix this is to either lower the tolerances (to probably only check one or none decimal places) or just remove the test altogether |
Isn't it just weird how all these bugs happened within the utilities functions only? Is it something related with this file specifically? Maybe some of the imports |
Pull request type
Please check the type of change your PR introduces:
Pull request checklist
Please check if your PR fulfills the following requirements, depending on the type of PR:
Code base additions (for bug fixes / features):
black rocketpy
) has passed locally and any fixes were madepytest --runslow
) have passed locallyWhat is the current behavior?
The getting_started example is too verbose, making it hard to read when one is first trying rocketpy;
What is the new behavior?
The classical apogee_by_mass function was moved from the getting started notebook to the utilities file. This was inspired by: https://github.com/RocketPy-Team/Hackathon_2020/pull/85
Does this introduce a breaking change?
Other information