MAINT: move aero surface plots and prints #381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is important to keep the same behavior as other rocketpy classes Having info() and allInfo() is already tradition in rocketpy
Gui-FernandesBR
added
Refactor
Outputs
MateusStano
requested changes
Jun 23, 2023
tests/test_rocket.py
Outdated
Comment on lines
94
to
95
| # Check if draw method is working properly | ||
| assert FinSet.draw() == None |
There was a problem hiding this comment.
The Fin.draw() method doesn't exist anymore. Only the Fin.plots.draw()
There was a problem hiding this comment.
If you really want to, we can create a draw() method inside each of the Fins classes, which will return self.plots.draw(), but I honestly don't see how that could be helpful.
|
Ready for a re-review @MateusStano |
MateusStano
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Pull request checklist
Code base maintenance (refactoring, formatting, renaming):
black rocketpy) has passed locally and any fixes were madepytest --runslow) have passed locallyWhat is the new behavior?
Does this introduce a breaking change?
Other information