Bug/flight without rail buttons #383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gui-FernandesBR
added
Bug
|
Just noticed something, in some cases the forces on the rail buttons could be exclusively negatives, thus the max force is ambiguos.
|
MateusStano
reviewed
Jun 25, 2023
rocketpy/Flight.py
Outdated
Comment on lines
2241
to
2253
| @cached_property | ||
| def __rail_buttons_alpha_angle(self): | ||
| """Alpha angle of the rail buttons, in radians. If there is no rail | ||
| button, the function returns 0. See the rail buttons documentation to | ||
| learn more about the alpha angle. | ||
| """ | ||
| try: | ||
| alpha = self.rocket.rail_buttons[0].component.angular_position * ( | ||
| np.pi / 180 | ||
| ) | ||
| except IndexError: | ||
| alpha = 0 # there's no rail button defined, use any alpha value | ||
| return alpha |
There was a problem hiding this comment.
Alpha angle? What is this supposed to be?
Also this is not in the rail buttons documentation (I think....)
There was a problem hiding this comment.
Alpha is the angular position of the rail buttons.
I agree this could be better described
There was a problem hiding this comment.
Okay! I prefer if we just use angular_position as the name of this
| @@ -2531,7 +2508,7 @@ def retrieve_temporary_values_arrays(self): | |||
| return temporary_values | |||
|
|
|||
| @cached_property | |||
| def calculate_rail_button_forces(self): | |||
| def __calculate_rail_button_forces(self): | |||
There was a problem hiding this comment.
Any reason to make this private?
There was a problem hiding this comment.
- I just did not want to allow user to get the whole tuple of 4 Function objects.
- The return is a tuple of 4 elements describing the forces in the rocket coordinates system. This needs to be converted to "rail button" reference system. If we don't convert, we can't call it shear or normal force. I don't think it would be good if we set this "intermediate" result as public.
MateusStano
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
Pull request checklist
Please check if your PR fulfills the following requirements, depending on the type of PR:
Code base additions (for bug fixes / features):
black rocketpy) has passed locally and any fixes were madepytest --runslow) have passed locallyWhat is the current behavior?
What is the new behavior?
Does this introduce a breaking change?
Other information