Skip to content

MNT: add codecov integration #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 15, 2023

Conversation

Gui-FernandesBR
Copy link
Member

@Gui-FernandesBR Gui-FernandesBR commented Nov 10, 2023

Pull request type

  • Code changes (bugfix, features)
  • Code maintenance (refactoring, formatting, tests)
  • ReadMe, Docs and GitHub updates
  • Other (please describe):

Checklist

  • Tests for the changes have been added (if needed)
  • Docs have been reviewed and added / updated
  • Lint (black rocketpy/ tests/) has passed locally
  • All tests (pytest --runslow) have passed locally

Current behavior

We run tests everytime but we don't see the code coverage percentage

New behavior

Adding codecoverage integration according to this: https://app.codecov.io/gh/RocketPy-Team/RocketPy/new.
This still needs to be tested before merging.

Breaking change

  • Yes
  • No

Additional information

None

@Gui-FernandesBR Gui-FernandesBR added the C.I. Continuous Integration (Workflows and actions) label Nov 10, 2023
@Gui-FernandesBR
Copy link
Member Author

This is sad:

image

Copy link

codecov bot commented Nov 10, 2023

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@Gui-FernandesBR
Copy link
Member Author

Gui-FernandesBR commented Nov 10, 2023

Well, this is working. Can we merge it and test it at least until the end of the year to evaluate if this is working properly?

image

@Gui-FernandesBR Gui-FernandesBR linked an issue Nov 10, 2023 that may be closed by this pull request
1 task
@Gui-FernandesBR
Copy link
Member Author

Can you confirm that you can access this report? https://app.codecov.io/gh/RocketPy-Team/RocketPy/tree/mnt%2Fadd-codecov-integration/?displayType=list

@MateusStano MateusStano merged commit 93a062e into tst/update-workflows Nov 15, 2023
@MateusStano MateusStano deleted the mnt/add-codecov-integration branch November 15, 2023 21:48
@Gui-FernandesBR Gui-FernandesBR added this to the Release v1.X.0 milestone Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C.I. Continuous Integration (Workflows and actions)
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

Integrate with code coverage report
3 participants