TST: new set of tests #467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TST: added unit tests to rocketpy.Function, rocketpy.Rocket, rocketpy.Flight submodules.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #467 +/- ##
===========================================
- Coverage 70.87% 70.86% -0.01%
===========================================
Files 55 55
Lines 9223 9224 +1
===========================================
Hits 6537 6537
- Misses 2686 2687 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Gui-FernandesBR
approved these changes
Nov 18, 2023
There was a problem hiding this comment.
Nice work here, and very nice to see contributions from you again @lucasfourier !!
I made some tiny comments but overall the code is already improving our testing suit. Well done!
Made some changes according to the comments made in the PR.
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Checklist
black rocketpy/ tests/) has passed locallypytest --runslow) have passed locallyCurrent behavior
Tests won't pass with --runslow locally due to the following error:
"_tkinter.TclError: Can't find a usable tk.tcl in the following directories:"
which occurs non-deterministically. However, the newly implemented
tests passed locally with --runslow.
Enter text here...
New behavior
The test files test_flight, test_rocket and test_function have gained
new unit tests.
Breaking change
Additional information
Enter text here...