MNT: update Makefile

[Gui-FernandesBR]

Pull request type

• ReadMe, Docs and GitHub updates

Checklist

• Tests for the changes have been added (if needed) [not relevant]
• Docs have been reviewed and added / updated
• Lint (black rocketpy/ tests/) has passed locally
• All tests (pytest --runslow) have passed locally
• CHANGELOG.md has been updated (if relevant) [not relevant]

Current behavior

The current Makefile is dated from more than 2 years ago, and I'm under the impression that almost none of our developers (including me) use it so often.

New behavior

I updated (and hopefully improved) the Makefile, now adding new commands to help us during development phase.
You can now use the following commands:

• make pytest
• make slow
• make coverage
• make coverage-report
• make install
• make isort
• make black
• make pylint
• make build-docs

Breaking change

• No

Additional information

• There's a strange error happening when running make pylint, but it is being ignored by the - sign and should not affect the performance, so don't worry about that.
• Please ensure the commands are running properly in your local machines! I'm curious to see the behaviour when running in Windows, @MateusStano .

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (435bd62) 72.32% compared to head (5234f6d) 72.32%.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop     #539   +/-   ##
========================================
  Coverage    72.32%   72.32%           
========================================
  Files           56       56           
  Lines         9399     9399           
========================================
  Hits          6798     6798           
  Misses        2601     2601           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[phmbressan]

I commited a mistake in which I removed the - sign you mentioned in the PR description. After noticing the problem, I returned things as they were.

However, after commiting, this triggered the lint GitHub action which oddly disagreed from the black of my PC. So it changed the formatting of some non-related files.

Do you have any ideas why this might be happening @Gui-FernandesBR ?

[Gui-FernandesBR]

I commited a mistake in which I removed the - sign you mentioned in the PR description. After noticing the problem, I returned things as they were.

However, after commiting, this triggered the lint GitHub action which oddly disagreed from the black of my PC. So it changed the formatting of some non-related files.

Do you have any ideas why this might be happening @Gui-FernandesBR ?

that's weird man. Let's update the branch with a rebase and wait to see what is happening

[Gui-FernandesBR]

Ok, I understand it now, there's a new version of black out there, this is creating some formatting differences (https://pypi.org/project/black/).

I think it is OK to include the linter changes in this PR, no big deal.

Please update your black: pip install black --upgrade

[phmbressan]

@MateusStano could you test some of these commands in Windows, because I am afraid changing the Python command from python to python3 might cause some issues.

[MateusStano]

@MateusStano could you test some of these commands in Windows, because I am afraid changing the Python command from python to python3 might cause some issues.

Yep, python3 does not work on windows

[MateusStano]

By the way, it seems that the requirements-tests.txt file is requiring pytest==6.2.4. Pytest is already in version 8.0, might be good to change that

[phmbressan]

By the way, it seems that the requirements-tests.txt file is requiring pytest==6.2.4. Pytest is already in version 8.0, might be good to change that

I have removed the versioning cap and the tests still ran fine. If there was a specific reason to keep the cap, please correct me.

[phmbressan]

@MateusStano could you test some of these commands in Windows, because I am afraid changing the Python command from python to python3 might cause some issues.

Yep, python3 does not work on windows

I believe I have found a solution to set the Environment variable according the common definition of the UNIX and Windows. Of course, if the user changed that it will fail.

Could you test them on Windows again, just to make sure it is working?

[Gui-FernandesBR]

Great adjustments, I wanted to confirm the code is working on linux.

Asking help from windows developers here @MateusStano @giovaniceotto @lucasfourier @juliomachad0

It is latterly checking out the mnt/update-makefile branch and running "make X" as described in the PR description.
I'm gonna restore my windows machine in the short-term future to avoid inconveniences like this.

[Gui-FernandesBR]

Just tested on windows now with @juliomachad0 's help, everything works, amazing!