Skip to content

DOC: Add a doctest to calculate density profile #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 2, 2024

Conversation

justincolinsmart
Copy link
Contributor

Pull request type

  • ReadMe, Docs and GitHub updates

Checklist

  • Docs have been reviewed and added / updated
  • Lint (black rocketpy/ tests/) has passed locally

Current behavior

Previously environment.calculate_density_profile lacked doctest

New behavior

Now environment.calculate_density_profile now has two doctest's, one for sea level and another at 1000m

Breaking change

  • No

@justincolinsmart justincolinsmart added the Docs Docs and examples related label Apr 27, 2024
@justincolinsmart justincolinsmart added this to the Release v1.X.0 milestone Apr 27, 2024
@justincolinsmart justincolinsmart self-assigned this Apr 27, 2024
@justincolinsmart justincolinsmart requested a review from a team as a code owner April 27, 2024 00:47
Copy link
Member

@Gui-FernandesBR Gui-FernandesBR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, @justincolinsmart ! Good to see you here.

Overall, the PR looks good, straight to the point,

Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.97%. Comparing base (1b9e950) to head (e5d6fce).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #591   +/-   ##
========================================
  Coverage    72.97%   72.97%           
========================================
  Files           57       57           
  Lines         9596     9596           
========================================
  Hits          7003     7003           
  Misses        2593     2593           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phmbressan phmbressan merged commit 880afb1 into develop May 2, 2024
@phmbressan phmbressan deleted the doc/doctest-enviroment branch May 2, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs Docs and examples related
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

3 participants