Release 0.21.0 #721
Release 0.21.0 #721
Conversation
|
There are may API changes. 0.30 maybe? // Who does not like bike-shedding? |
luckily we do not need to make that decision, semver (https://semver.org) has done it for us :) I do like the idea of a 1.0.0 eventually. We can probably do that after:
|
|
As you mentioned already thousands of projects depend on it and it is sad fact of live that people generally do not read documentation, including semantic versioning guides. No problem picking next minor version, of course. |
|
I'll place an announcement on reddit and the rust user forum noting its a breaking release and explicitly mention the upgrade guide and documentation. maybe that will help |
|
Ready for review and then release. I would prefer to release either next monday or before friday this week. Since during the weekend I can not handle any fallout/questions. |
|
On a business trip now, could offer a few nitpicks but would have to do it on mobile (biggest one: gapless is only with Symphonia, and already was in 0.20 - biggest fix here is the availability of Come to think of, there are also some function return type changes in the Overarching question: the way I perceive the upgrade guide, it's indeed to migrate and fix compilation issues. I'm wondering if we should shed a little more light on some internals; the |
|
another thing, bincode has the migration guide in the docs, seems like a good idea to me. |
|
blocked by #724 |
thank you very much, I'll get on that some day next week. Next time full free to edit the code/docs on the branch directly. Then I'll just look at the diff and bring up any contentious change. |
|
blocked by #730 |
|
rebased on main |
dvdsk
force-pushed
the
0.21
branch
3 times, most recently
from
6d9b6c9 to
d58968b
Compare
|
rebased on master |
dvdsk
force-pushed
the
0.21
branch
3 times, most recently
from
ac0b1b8 to
946cce2
Compare
|
we should be good to release now :) |
| other contributors helping out. Thanks to you all this release: | ||
|
|
||
| - Makes the API easier to use: | ||
| - Its now impossible to accidentally drop the `Outputstream`. |
There was a problem hiding this comment.
unfortunately this is not true, I must have misremembered... (at least a quick check with the music_flac example shows it to be false)
| @@ -40,6 +42,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| - Breaking: `ReadSeekSource::new()` now takes `Settings`. | |||
| - Breaking: Sources now use `f32` samples. To convert to and from other types of samples use | |||
| functions from `dasp_sample` crate. For example `DaspSample::from_sample(sample)`. | |||
| - Breaking: `symphonia::SeekError` has a new variant `AccurateSeekNotSupported` | |||
There was a problem hiding this comment.
We may also want to add:
Breaking: `symphonia::SeekError` has a new variant `RandomAccessNotSupported`. This error usually means that you are trying to seek backward without `is_seekable` or `byte_len` set: use `Decoder::try_from` or `DecoderBuilder` for that.
| @@ -51,7 +56,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| correctly. | |||
| - Removed unwrap() calls in MP3, WAV, FLAC and Vorbis format detection for better error handling. | |||
| - `LoopedDecoder::size_hint` now correctly indicates an infinite stream. | |||
| - Symphonia decoder `total_duration` for Vorbis now return the correct value (#696). | |||
| - Symphonia decoder `total_duration` no longer returns None when it could | |||
There was a problem hiding this comment.
Nitpick: want to use None and Some (with backticks?)
| - Adds new functionality: | ||
| - Amplify using decibals or perceptually. | ||
| - Add a distortion effect. | ||
| - You can use rodio without `cpal` to generate `wav` files! |
There was a problem hiding this comment.
Want to highlight the decoder builder as well?
|
Mind if I suggest you include #754 in this release as well? |
Chores: