Skip to content
This repository was archived by the owner on Mar 27, 2024. It is now read-only.

Run 'cargo fmt'; add 'cargo fmt' check to travis #102

Merged
merged 6 commits into from
Nov 3, 2019
Merged

Conversation

crsaracco
Copy link
Member

@crsaracco crsaracco commented Jul 13, 2019

Enable cargo fmt checking in our travis CI builds.

This PR unfortunately breaks a bunch of our git history, but it should prevent the same problem from happening again in the future -- unless we change rustfmt.toml, which is super basic right now. Not sure if there's anything else we'd like to add to it.

PRs will now fail the travis CI if it hasn't been cargo fmt'd.

@crsaracco crsaracco changed the title [WIP] Run 'cargo fmt'; add 'cargo fmt' check to travis Run 'cargo fmt'; add 'cargo fmt' check to travis Jul 13, 2019
Copy link
Contributor

@askeksa askeksa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting changes look reasonable.

The changes to test formatting go through Travis, so i guess those are fine as well.

Copy link
Contributor

@Walther Walther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@crsaracco crsaracco merged commit aa7cc43 into master Nov 3, 2019
@crsaracco crsaracco deleted the rustfmt-ci branch November 3, 2019 17:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants