Add BoxedUint::{from_be_slice_vartime, from_le_slice_vartime}
#833
+60
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds methods for decoding `BoxedUint` which infer the precision from the input size. This is useful for decoding public parameters, especially when the size of other parameters is inferred from some public parameter that needs to be decoded first, e.g. RSA modulus.
|
Not sure this is the greatest name or implementation. Notably the existing These methods are unsuitable for use on secret values, however, so |
baloo
reviewed
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds methods for decoding
BoxedUintwhich infer the precision from the input size.This is useful for decoding public parameters, especially when the size of other parameters is inferred from some public parameter that needs to be decoded first, e.g. RSA modulus.