Skip to content

k256: remove Scalar::conditional_add_bit #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2021

Conversation

tarcieri
Copy link
Member

The case it's actually being used for in practice is much simpler and can be easily expressed using the current functionality.

The case it's actually being used for in practice is much simpler and
can be easily expressed using the current functionality.
@tarcieri tarcieri requested a review from fjarri September 13, 2021 14:21
@codecov-commenter
Copy link

Codecov Report

Merging #431 (ebea79b) into master (f594fd4) will decrease coverage by 0.03%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #431      +/-   ##
==========================================
- Coverage   64.74%   64.70%   -0.04%     
==========================================
  Files          28       28              
  Lines        3602     3598       -4     
==========================================
- Hits         2332     2328       -4     
  Misses       1270     1270              
Impacted Files Coverage Δ
k256/src/arithmetic/scalar.rs 84.13% <ø> (-0.22%) ⬇️
k256/src/arithmetic/scalar/wide32.rs 0.00% <0.00%> (ø)
k256/src/arithmetic/scalar/wide64.rs 95.78% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f594fd4...ebea79b. Read the comment docs.

@fjarri
Copy link
Contributor

fjarri commented Sep 14, 2021

Just as a general information: in libsecp256k1, the analogue of this function (secp256k1_scalar_cadd_bit()) is only ever used with a non-zero shift in secp256k1_wnaf_const().

@tarcieri tarcieri merged commit df71290 into master Sep 14, 2021
@tarcieri tarcieri deleted the k256/remove-conditional-add-bit branch September 14, 2021 01:28
This was referenced Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants