der: remove 256 MiB limit on Length
#1726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You seem to have started from an out-of-date copy of the repo. This also makes significantly more changes than what's in the title of the issue. I would suggest starting by simply removing the limit. |
turbocool3r
force-pushed
the
large-length
branch
from
558f313 to
4dfc971
Compare
|
@tarcieri sure, will change back to |
turbocool3r
force-pushed
the
large-length
branch
2 times, most recently
from
6b8345d to
76ce308
Compare
turbocool3r
force-pushed
the
large-length
branch
from
76ce308 to
cca2604
Compare
tarcieri
approved these changes
Mar 17, 2025
tarcieri
changed the title
LengthLength
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lengthtype was previously limited to 256 MiB. This PR removes the limit and changes the internal representation tousizeinstead ofu32.