der: remove IndefiniteLength
#1807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original idea of this type was to have a type-safe distinction between DER lengths (`Length`) and potentially indefinite BER lengths (`IndefiniteLength`), but really what's needed is to make the `Length` type support idefinite lengths when `EncodingRules::Ber` are in use. Otherwise, we need to change `Header` to use `IndefiniteLength`, which kind of defeats the point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original idea of this type was to have a type-safe distinction between DER lengths (
Length) and potentially indefinite BER lengths (IndefiniteLength), but really what's needed is to make theLengthtype support idefinite lengths whenEncodingRules::Berare in use.Otherwise, we need to change
Headerto useIndefiniteLength, which kind of defeats the point.