fix: CORUI-6949: add onBlur callback to DatePicker #712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for fundamental-react ready! Built with commit 88c26cc |
|
Deploy preview for fundamental-react ready! Built with commit a1ec193 |
greg-a-smith
suggested changes
Aug 13, 2019
src/DatePicker/DatePicker.js
Outdated
| @@ -303,6 +308,8 @@ class DatePicker extends Component { | |||
| <input | |||
| {...inputProps} | |||
| className={datePickerInputClasses} | |||
| onBlur={() => onBlur({ date: this.state.selectedDate, | |||
| formattedDate: this.state.formattedDate })} | |||
There was a problem hiding this comment.
This would be better written as a separate function in the component and then referenced here like onBlur={this._handleBlur}. Otherwise, this actually creates a new instance of the function each time it goes through the render function.
src/DatePicker/DatePicker.js
Outdated
| }; | ||
|
|
||
| DatePicker.propDescriptions = { | ||
| ...Calendar.propDescriptions, | ||
| enableRangeSelection: 'Set to **true** to enable the selection of a date range (begin and end).' | ||
| enableRangeSelection: 'Set to **true** to enable the selection of a date range (begin and end).', | ||
| onBlur: 'Callback function for onBlur events. In the object returned, date is the date object and formattedDate is the formatted date.' |
There was a problem hiding this comment.
Maybe add backticks around date and formattedDate when describing the returned object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Without doing a full rewrite at the moment, this is as close to a functional callback as we can get. Tests were a nightmare, so I decided to forgo them for this bandaid.
This behaves slightly erratically as the input is not wired up to the calendar/sharing validation.
Known bugs: Changes to the input don't necessarily update the date/trigger any event.
fixes #498