Skip to content

Don't require NSObject for tests #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 6, 2015
Merged

Don't require NSObject for tests #32

merged 4 commits into from
Dec 6, 2015

Conversation

SSheldon
Copy link
Owner

Apple's Objective-C runtime includes the definition of NSObject, so it had been used in the tests for convenience. However, NSObject isn't defined by the GNUstep runtime, so we had to add the test_ns_object crate to define it for GNUstep.

The tests don't actually need NSObject though, so with a little bit more work we can make one of the test classes a root class and use it instead.

@SSheldon
Copy link
Owner Author

cc @ngrewe, I think this will make maintaining the GNUstep feature easier, let me know if you have any thoughts on this.

@ngrewe
Copy link
Contributor

ngrewe commented Dec 1, 2015

I like the idea. Do you think it might be a useful to factor this out into a separate crate to share as a dev-dependency for the other Obj-C interop crates?

@SSheldon
Copy link
Owner Author

SSheldon commented Dec 6, 2015

@ngrewe I can only imagine this being useful if all you want is to make sure sending messages is working, and the only crate I can imagine wanting to test that is this one 😄 If you come across any crates where it'd be useful I'm happy to extract it!

@SSheldon SSheldon merged commit b9e0772 into master Dec 6, 2015
@SSheldon SSheldon deleted the no_nsobject branch December 6, 2015 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants