Skip to content

Update README.md #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2020
Merged

Update README.md #610

merged 1 commit into from
Aug 2, 2020

Conversation

rokx
Copy link
Contributor

@rokx rokx commented Jun 17, 2020

Mentioned that internet access is required in Prerequisites.

Mentioned that internet access is required in Prerequisites.
@SamProf
Copy link
Owner

SamProf commented Jul 5, 2020

Hi, I am not sure that internet is required. Maybe only font's will have some problems. But this also can be resolved.

@rokx
Copy link
Contributor Author

rokx commented Jul 10, 2020

Look at
https://github.com/SamProf/MatBlazor/blob/master/src/MatBlazor/wwwroot/dist/matBlazor.css

You are referencing https://fonts.googleapis.com.

I would consider it a requirement.
These fonts are generated based on the client that is requesting them. It is not a trivial task of just downloading a font file.

@SamProf SamProf changed the base branch from master to develop August 2, 2020 15:13
@SamProf SamProf merged commit d28cf1d into SamProf:develop Aug 2, 2020
@SamProf
Copy link
Owner

SamProf commented Aug 2, 2020

Yeah, sure.
Maybe i need to think how I can integrate fonts to deployment. But for now you right - internet is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants