ARCore 1.26.0, Filament 1.12.0 Update. Refactoring #143

RGregat · 2021-08-18T14:57:53Z

Changed

Updated build.gradle parameters
- compileSdkVersion 30 -> 31
- targetSdkVersion 30 -> 31
- sourceCompatibility VERSION_1_8 -> VERSION_11
- targetCompatibility VERSION_1_8 -> VERSION_11
Updated dependencies
- filament 1.10.7 -> 1.12.0
- arcore 1.25.0 -> 1.26.0
- appcompat 1.2.0 -> 1.3.1
Compiled filament materials for version 1.12.0
Refactored a few big functions and splitted them into smaller parts
Updated and tested all samples

Fixed

Fixed a few deprecation warnings
In CameraStream the function initializeTexture was called twice. This is now fixed

Added

Added in BaseArFragment a new function to close a session

public void closeSession() {
    if(arSceneView.getSession() != null)
        arSceneView.getSession().close();
        arSceneView.setSession(null);
    }
}

* Splitted up the `render` function from the Sceneform Renderer class into smaller parts. * The Filament renderer `begingFrame` function call is now before anything ArCore related is updated. * Swapped order of the `doUpdate` and `doRender` function call in SceneView. * Added `Choreographer.getInstance().removeFrameCallback(this);` to the destroy function call in SceneView. * Splitted up the `onBeginFrame`function in ArSceneView a little bit. * Added to BaseArFragment a new function to close the session and set the variable to null. `

* compileSdkVersion 30 -> 31 * targetSdkVersion 30 -> 31 * sourceCompatibility VERSION_1_8 -> VERSION_11 * targetCompatibility VERSION_1_8 -> VERSION_11 * filament 1.10.7 -> 1.12.0 * arcore 1.25.0 -> 1.26.0 * appcompat 1.2.0 -> 1.3.1

…skip the render call

ThomasGorisse

Thanks for this PR @RGregat !!!
I'm back from holidays and currently reviewing it.
Please don't commit right now since I'm also bringing some cleanup here.
Can you just answer questions first?

core/src/main/java/com/google/ar/sceneform/rendering/ExternalTexture.java

core/src/main/java/com/google/ar/sceneform/rendering/Renderer.java

core/src/main/java/com/google/ar/sceneform/ArSceneView.java

...ented-images/src/main/java/com/google/ar/sceneform/samples/augmentedimages/MainActivity.java

ThomasGorisse · 2021-08-19T15:06:54Z

samples/sceneview-background/src/main/res/layout/activity_main.xml

@@ -26,7 +26,8 @@
            android:id="@+id/transparentSceneView"
            android:layout_width="match_parent"
            android:layout_height="0dp"
-            android:layout_weight="1" />
+            android:layout_weight="1"
+            android:background="#FF0000FF"/>


Does our dragon transparency issue comes from the background?

Yeah I added the blue color in the last version to see if the issue comes from that. I changed it back to transparent. By the way, everything ist rendering now again, maybe because of the Filament update in this version.

Can you simply check if the DragonAttenuation.glb (transparency one) is displayed correctly on your devices?
It's not the case on my Pixel 4a.

core/build.gradle

…t everything is well called - Add setters for ArFragment and ArSceneview Session and Session Config - Improve session.getConfig() calls - Review the SceneView/ArSceneView resume/pause order - Remove the ensure updateMode == Config.UpdateMode.LATEST_CAMERA_IMAGE - Cleanup - Improvements

* Replaced `requestPermissions` and `onRequestPermissionResult` with the new way by creating a `ActivityResultLauncher` object. The result of the request is handled via a callback function.

… transparent again. * Both dragons and backdrops are rendered.

RGregat · 2021-08-20T08:56:41Z

I find it a little bit difficult to profile and analyze the memory footprint of Sceneform on my laptop. The Laptop is not strong enough :).
Here is a visualization of a captured java/kotlin object allocation, when the gltf sample app was running.

As you can see the allocation rate rises continuously until the GC is cleaning unused objects. From the result I can't tell if the Trackable object allocation every frame has a huge impact. But the PlaneRenderer has still a huge impact.

RGregat · 2021-08-20T08:58:56Z

Ok found the updateTrackable calls

looks not so bad, especially if you compare it with the PlaneRenderer

ThomasGorisse · 2021-08-20T09:46:13Z

You are right, the updateTrackable doesn't consume so much but the problem was/is that it generates leaks since the created Trackable array elements are never cleaned and each call generates new ones. That made/makes a good part of the memory consumption increasing from what I think.

For the PlaneRender, we should check why normalToTangent is taking so much.

RGregat · 2021-08-20T11:10:40Z

You are right, the updateTrackable doesn't consume so much but the problem was/is that it generates leaks since the created Trackable array elements are never cleaned and each call generates new ones. That made/makes a good part of the memory consumption increasing from what I think.

For the PlaneRender, we should check why normalToTangent is taking so much.

Maybe this is something for a separate Branch/PR?

r.gregat added 10 commits August 16, 2021 10:49

Fixed unnecessary creation of a camere Texture.

2aa001b

Recompiled filament materials to 1.12.0

72e87ae

Updated dependencies

dd8820e

* compileSdkVersion 30 -> 31 * targetSdkVersion 30 -> 31 * sourceCompatibility VERSION_1_8 -> VERSION_11 * targetCompatibility VERSION_1_8 -> VERSION_11 * filament 1.10.7 -> 1.12.0 * arcore 1.25.0 -> 1.26.0 * appcompat 1.2.0 -> 1.3.1

Added different sample glb files.

173408e

Updated sample applications.

d8f3c7b

Compiled missing filament materials

0556a8c

Updated for the augmented-images sample app the filament dependency

35aca73

replaced deprecated code

ddb41e0

Instead of throwing an AssertionError if the SwapChain is null, just …

784519f

…skip the render call

ThomasGorisse self-requested a review August 19, 2021 12:32

ThomasGorisse self-assigned this Aug 19, 2021

ThomasGorisse added the enhancement New feature or request label Aug 19, 2021

ThomasGorisse approved these changes Aug 19, 2021

View reviewed changes

ThomasGorisse and others added 7 commits August 20, 2021 01:18

Add/Remove files

7ad4357

Set the TonMapper for the Filament-Renderer to FILMIC

2741376

Removed the manual setted TonMapper from every sample app

382bccb

gradle stuff

0005ef5

Fixed deprecation warning.

353704d

* Replaced `requestPermissions` and `onRequestPermissionResult` with the new way by creating a `ActivityResultLauncher` object. The result of the request is handled via a callback function.

Made the second half of the layout of the sceneview-background sample…

d975d8b

… transparent again. * Both dragons and backdrops are rendered.

ThomasGorisse merged commit 0c59e5e into master Aug 20, 2021

ThomasGorisse deleted the refactor/minor_cleanup branch August 20, 2021 12:50

ThomasGorisse linked an issue Aug 26, 2021 that may be closed by this pull request

Screen flickering during render - Augmented Image Demo #148

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

ARCore 1.26.0, Filament 1.12.0 Update. Refactoring #143

ARCore 1.26.0, Filament 1.12.0 Update. Refactoring #143

Uh oh!

RGregat commented Aug 18, 2021

Uh oh!

ThomasGorisse left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ThomasGorisse Aug 19, 2021

Uh oh!

RGregat Aug 20, 2021

Uh oh!

ThomasGorisse Aug 20, 2021

Uh oh!

Uh oh!

RGregat commented Aug 20, 2021

Uh oh!

RGregat commented Aug 20, 2021

Uh oh!

ThomasGorisse commented Aug 20, 2021

Uh oh!

RGregat commented Aug 20, 2021

Uh oh!

Uh oh!

Uh oh!

ARCore 1.26.0, Filament 1.12.0 Update. Refactoring #143

ARCore 1.26.0, Filament 1.12.0 Update. Refactoring #143

Uh oh!

Conversation

RGregat commented Aug 18, 2021

Uh oh!

ThomasGorisse left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ThomasGorisse Aug 19, 2021

Choose a reason for hiding this comment

Uh oh!

RGregat Aug 20, 2021

Choose a reason for hiding this comment

Uh oh!

ThomasGorisse Aug 20, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

RGregat commented Aug 20, 2021

Uh oh!

RGregat commented Aug 20, 2021

Uh oh!

ThomasGorisse commented Aug 20, 2021

Uh oh!

RGregat commented Aug 20, 2021

Uh oh!

Uh oh!