Skip to content

Add react-jsx to jsconfig schema jsx property #1410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 18, 2020

Conversation

mjbvz
Copy link
Contributor

@mjbvz mjbvz commented Dec 17, 2020

Ports #1357 to the jsconfig schema as well

Fixes microsoft/vscode#112710

@@ -111,8 +111,8 @@
"default": false
},
"jsx": {
"description": "When down-level compiling, specify JSX code generation: 'preserve', 'react', or 'react-native'. Requires TypeScript version 2.2 or later.",
Copy link
Contributor Author

@mjbvz mjbvz Dec 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the Requires TypeScript part of the description since it is not present in the tsconfig schema

@madskristensen
Copy link
Contributor

Let me know when this is ready to merge

@mjbvz
Copy link
Contributor Author

mjbvz commented Dec 17, 2020

Should be ready now. The feature was added in the latest stable TS release

@madskristensen madskristensen merged commit c8960eb into SchemaStore:master Dec 18, 2020
@madskristensen
Copy link
Contributor

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jsconfig.json does not support jsx=reaxt-jsx
2 participants