Skip to content

piecewise rewritten, math constants added to tagmap, warning solved! #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 23, 2021
Merged

Conversation

shahriariravanian
Copy link
Contributor

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 678255857

  • 11 of 18 (61.11%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-2.7%) to 61.25%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/parse.jl 11 12 91.67%
src/maps.jl 0 6 0.0%
Totals Coverage Status
Change from base Build 676756451: -2.7%
Covered Lines: 98
Relevant Lines: 160

💛 - Coveralls

@codecov
Copy link

codecov bot commented Mar 23, 2021

Codecov Report

Merging #24 (23a274a) into main (0b85c73) will decrease coverage by 2.67%.
The diff coverage is 61.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
- Coverage   63.92%   61.25%   -2.68%     
==========================================
  Files           4        4              
  Lines         158      160       +2     
==========================================
- Hits          101       98       -3     
- Misses         57       62       +5     
Impacted Files Coverage Δ
src/maps.jl 32.25% <0.00%> (-3.46%) ⬇️
src/parse.jl 96.77% <91.66%> (+1.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b85c73...23a274a. Read the comment docs.

@anandijain
Copy link
Contributor

looks good, thanks a ton!

@anandijain anandijain merged commit 5483f30 into SciML:main Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants