Add filter when saving dialogue #127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hchen2020
reviewed
Sep 1, 2023
| namespace BotSharp.Plugin.RoutingSpeeder.Controllers; | ||
|
|
||
| [AllowAnonymous] | ||
| public class TrainIntentClassifierController : ControllerBase |
There was a problem hiding this comment.
Please change name to RoutingSpeederController.
hchen2020
reviewed
Sep 1, 2023
| } | ||
|
|
||
| [HttpPost("/intent/classifier/training")] | ||
| public IActionResult TrainIntentClassifier(TrainingParams trainingParams) |
There was a problem hiding this comment.
/routingspeeder/classifier/train
hchen2020
reviewed
Sep 1, 2023
| @@ -32,6 +32,10 @@ public class IntentClassifier | |||
| public bool isModelReady => _isModelReady; | |||
| private ClassifierSetting _settings; | |||
|
|
|||
| private string[] _labels => GetLabels(); | |||
There was a problem hiding this comment.
GetLabels() will be always trigggered.
There was a problem hiding this comment.
Could I ask how to fix this?
There was a problem hiding this comment.
private string[] _labels;
public string Labels => GetLabels();
private string[] GetLabels()
{
if (_labels == null)
{
...
_labels = xxxxxx
}
return _labels;
}
hchen2020
reviewed
Sep 1, 2023
|
|
||
| var labels = GetLabels(); | ||
| var vector = _services.GetRequiredService<ITextEmbedding>(); |
There was a problem hiding this comment.
Should we use
var embedding = _services.GetServices<ITextEmbedding>()
.FirstOrDefault(x => x.GetType().FullName.EndsWith(knowledgeSettings.TextEmbedding));
hchen2020
reviewed
Sep 1, 2023
| @@ -10,4 +10,5 @@ public class TrainingParams | |||
| public int Epochs { get; set; } = 10; | |||
| public int BatchSize { get; set; } = 16; | |||
| public float LearningRate { get; set; } = 1.0e-4f; | |||
| public bool Reference { get; set; } = false; | |||
hchen2020
reviewed
Sep 1, 2023
| } | ||
|
|
||
| public string[] GetLabels() | ||
| { | ||
| var agentService = _services.CreateScope().ServiceProvider.GetRequiredService<IAgentService>(); | ||
| string rootDirectory = Path.Combine(agentService.GetDataDir(), _settings.MODEL_DIR, _settings.LABEL_FILE_NAME); | ||
| var labelText = File.ReadAllLines(rootDirectory); | ||
| return labelText.OrderBy(x => x).ToArray(); | ||
| return labelText.Select(x => x.Replace("intent.", "")).OrderBy(x => x).ToArray(); |
There was a problem hiding this comment.
Should keep prefix, the label name will be intent.xxxx.
hchen2020
reviewed
Sep 1, 2023
| labelList.AddRange(Enumerable.Repeat(fileName, texts.Count).ToList()); | ||
| } | ||
|
|
||
| // Write label into local file | ||
| var uniqueLabelList = labelList.Distinct().OrderBy(x => x).ToArray(); | ||
| var uniqueLabelList = labelList.Distinct().Select(x => x.Replace("intent.", "")).OrderBy(x => x).ToArray(); |
There was a problem hiding this comment.
Please keep intent prefix.
hchen2020
reviewed
Sep 1, 2023
| _service = service; | ||
| } | ||
|
|
||
| [HttpPost("/routingspeeder/classifier/train")] |
There was a problem hiding this comment.
/routing-speeder/classifier/train
hchen2020
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Training Controller, wrap up GetLabel&GetFiles function and Add new model parameters