Skip to content

wait LoadState.NetworkIdle after button clicked. #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 10, 2024
Merged

wait LoadState.NetworkIdle after button clicked. #297

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
421c65e
Delay more time when click button or element.
Feb 9, 2024
fa3fa88
Remove Hover
Feb 9, 2024
a5f8536
Merge branch 'SciSharp:master' into master
hchen2020 Feb 10, 2024
97eec08
wait LoadState.NetworkIdle after button clicked.
Feb 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...ins/BotSharp.Plugin.WebDriver/Drivers/PlaywrightDriver/PlaywrightWebDriver.ClickButton.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ public async Task<bool> ClickButton(BrowserActionParams actionParams)
{
await _instance.Page.WaitForLoadStateAsync(LoadState.DOMContentLoaded);
await _instance.Page.WaitForLoadStateAsync(LoadState.NetworkIdle);

await Task.Delay(100);

// Find by text exactly match
Expand Down Expand Up @@ -52,10 +51,11 @@ public async Task<bool> ClickButton(BrowserActionParams actionParams)

try
{
await elements.HoverAsync();
await elements.ClickAsync();

await Task.Delay(300);
await _instance.Page.WaitForLoadStateAsync(LoadState.NetworkIdle);
await Task.Delay(100);

return true;
}
catch (Exception ex)
Expand Down
3 changes: 2 additions & 1 deletion ...ns/BotSharp.Plugin.WebDriver/Drivers/PlaywrightDriver/PlaywrightWebDriver.ClickElement.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ public async Task<bool> ClickElement(BrowserActionParams actionParams)
{
await _instance.Page.WaitForLoadStateAsync(LoadState.DOMContentLoaded);
await _instance.Page.WaitForLoadStateAsync(LoadState.NetworkIdle);
await Task.Delay(100);

// Retrieve the page raw html and infer the element path
var regexExpression = actionParams.Context.MatchRule.ToLower() switch
Expand Down Expand Up @@ -37,11 +38,11 @@ public async Task<bool> ClickElement(BrowserActionParams actionParams)
{
// var tagName = await elements.EvaluateAsync<string>("el => el.tagName");

await elements.HoverAsync();
await elements.ClickAsync();

// Triggered ajax
await _instance.Page.WaitForLoadStateAsync(LoadState.NetworkIdle);
await Task.Delay(100);

return true;
}
Expand Down