Various fixes regarding special tokens (embeddings & anti-prompt) #1112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martindevans
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed some issues with the following:
Fixed special tokens parsing as plain text in LLamaEmbedder
Fixed anti-prompt passing as plain text in InteractiveExecutor
BatchedExecutorBoolQ example now tokenizes special tokens
I wonder if at this point it's worth making the default
Tokenize()parameter bespecial = trueinstead,.. because every single one of the library's calls seems to be needing this to be set as
true:Although if you think it's safest for users if accidental special are parsed as plain text I can understand that too.