Skip to content

Fixed Spelling Mirostate -> Mirostat #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2023

Conversation

martindevans
Copy link
Member

@martindevans martindevans commented Jul 27, 2023

The "mirostat" sampler was misspelled as "mirostate" in a few places. This initially confused me, as I was googling it to try and discover was mirostate is!

This technically is a breaking change, since it changes the name of the enum.

@AsakusaRinne
Copy link
Collaborator

AsakusaRinne commented Aug 5, 2023

Oh...That's my bad, I mistoken stat as the short of state. Could you please tell me what is stat meaning?

@AsakusaRinne AsakusaRinne merged commit c641dbd into SciSharp:master Aug 5, 2023
@martindevans martindevans deleted the fixed_mirostat_spelling branch August 5, 2023 00:59
@martindevans
Copy link
Member Author

Could you please tell me what is stat meaning?

I wasn't sure what the name meant before you asked. I did some searching it turns out the original paper actually explains it at the bottom of the first page: The word mirostat is derived from "mirum" which is Latin for "surprise" and "stat" meaning "control".

@AsakusaRinne
Copy link
Collaborator

I wasn't sure what the name meant before you asked. I did some searching it turns out the original paper actually explains it at the bottom of the first page: The word mirostat is derived from "mirum" which is Latin for "surprise" and "stat" meaning "control".

Got it, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants