Skip to content

Feature Optional numba #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

mauicv
Copy link
Contributor

@mauicv mauicv commented Jun 22, 2022

Todo:

  • Tox env tests

What is this

This work branches off feature/dep-management and will make numba optional dependency of alibi-detect.


What this PR doesn't include:

  1. The install options in the docs. I think it makes sense to do this in a later PR on the feature branch for all the optional deps all at once, once this branch has been merged in.
  2. The install options in the README.md for same reason as 1.
  3. The config-driven work in the release branch. This will be done in a separate PR in order to manage Release/Master branch complexity issues.
  4. Make Licenses updates. This will be done in a PR on the feature branch.

Notes:

@mauicv mauicv changed the base branch from master to feature/dep-management June 22, 2022 13:47
@mauicv mauicv changed the title Feature/optional numba Feature Optional numba Jun 23, 2022
@ascillitoe
Copy link
Contributor

@mauicv re the typing errors, the pytorch/kernels.py and pytorch/context_aware.py ones only seem to occur with numpy>=1.23.0. numba 0.55.2 requires numpy<1.23 hence these only became apparent when you removed numba from the CI install env. Still good you've fixed them imo.

Re #540 I'm still looking into that one...

@ascillitoe ascillitoe mentioned this pull request Jul 5, 2022
2 tasks
@mauicv mauicv force-pushed the feature/dep-management branch from 5047c71 to a7c883d Compare July 8, 2022 08:36
@ascillitoe ascillitoe modified the milestone: v0.10.0 Jul 12, 2022
@mauicv mauicv closed this Jul 22, 2022
@ascillitoe ascillitoe mentioned this pull request Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants