-
Notifications
You must be signed in to change notification settings - Fork 229
Serialisation of (online) state for online detectors #604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
2171395
Initial implementation of save/load state for LSDDDriftOnlineTorch
68883d4
Add tests for saving state
944a65d
WIP: LSDDDriftOnlineTF implementation
672fbcc
State save/load/reset for online LSDD (tf) and MMD (pt and tf)
9411d54
Online FET and CVM implementation
d3c397a
Update LSDD and MMD to reset via reset() rather than reset_state()
06a032b
use .get for state_dict in mmd/lsdd for consistency
9ea9339
WIP: saving state via save_detector. Need to add tests
faa483b
Fixes, and tests for save_detector save_state kwarg
ec48bb6
Merge branch 'master' into feature/save_state
6deb17f
Fix tests
272ef3a
Update changelog
e9c3685
Update docs
f73fbbf
POC of refactoring. LSDDDriftOnlineTorch only
09c4305
Refactor initialise methods (and tests)
1774ee9
Move save/load_state to base classes
d9d2e25
Manage online test seeds with fixed_seed
975094e
Add missing _state.py files
363b435
Fix ops deps tests
cfc8918
Remove misplaced offline_state code
30bc57a
Fix test_saving
1d81d35
Merge branch 'master' into feature/save_state
2d9c5cf
Remove uneccesary Framework import
bb53453
Simplify online state tests
bb4035a
Incorperate some updates from feature/save_offline_state
430ebd5
Revert 21519e4, but keep changes to tests and additions to online_sta…
91e1b61
Test saving of state for all online detectors in test_saving.py
9e84410
Added logging messages
5dea156
Remove old _set_state_path method
785365d
Make StatefulDetector inherit from ConfigurableDetector
7ce6476
Replace indexing with tf.gather
a2bce2b
Merge branch 'fix/tf_indexing_bug' into feature/save_state
b2806cc
Add filepath check back to _load_detector_config
2d4b6a3
Rename StatefulDetector to StatefulDetectorOnline
67915b8
Add online_state_keys attr to StatefulDetectorOnline
feb9fda
Revert "Add online_state_keys attr to StatefulDetectorOnline"
aa6b0d3
Rename rest to reset_state
15d1dfa
Update typings
da56714
Remove extra parentheses
6240fdf
Remove unused seed's in tests
5daf1b1
Add BaseDriftOnline class
c7d72c7
Add description for BaseUniDriftOnline
d190589
Remove save_state kwarg from save_detector
4de6fad
Move state methods to StateMixin
7b824d8
Update docs
d888276
Only mention .predict() in saving page
1026713
Move conftest.py's containing seed fixture to local test dirs
828e486
Add missing conftest
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean
score()
instead ofstate()
? On that note, do we even document the usage/use cases ofscore()
? If not, perhaps should leave it out.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good spot thanks. Also fair point about not really documenting it. I'll remove.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed
.state()
in d888276