Skip to content

Grid 4. Unable to limit number of maxSession within node via passing NODE_MAX_SESSION=3 #1128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
seoslav opened this issue Oct 18, 2020 · 6 comments
Assignees

Comments

@seoslav
Copy link

seoslav commented Oct 18, 2020

🐛 Bug Report

Grid 4. Unable to limit number of maxSession within single node via passing NODE_MAX_SESSION=3 either on hub or node level.

To Reproduce

Detailed steps to reproduce the behavior:

  1. Create hub
    docker run -d -p 4442-4444:4442-4444 -e NODE_MAX_SESSION=3 -e NODE_MAX_INSTANCES=1 -e GRID_MAX_SESSION=5 --net grid --name selenium-hub selenium/hub:4.0.0-alpha-7-prerelease-20201009
  2. Create at least one node:
    docker run -d --net grid -e SE_EVENT_BUS_HOST=selenium-hub -e SE_EVENT_BUS_PUBLISH_PORT=4442 -e SE_EVENT_BUS_SUBSCRIBE_PORT=4443 -e NODE_MAX_SESSION=3 -e NODE_MAX_INSTANCES=1 -v /dev/shm:/dev/shm selenium/node-chrome:4.0.0-alpha-7-prerelease-20201009
  3. Check status page:
    "value": { "ready": true, "message": "Selenium Grid ready.", "nodes": [ { "id": "a07dfee7-5136-4753-beb6-53c791536c83", "uri": "http:\u002f\u002f172.22.0.3:5555", "maxSessions": 4, "slots": [

Expected behavior

MAX_SESSION=3

Environment

OS: Windows 10
Browser: Chrome
Selenium Grid version (if applicable): 4.0.0

@raju249 raju249 self-assigned this Oct 27, 2020
@raju249
Copy link
Member

raju249 commented Oct 27, 2020

Hi @seoslav 👋

Thanks for the issue. I think this is fix on the docker config. We support an option as --max-sessions but the docker config for Hub and Node uses max-session which is incorrect.

/cc - @diemol

@ghost ghost added the needs-triaging label Oct 27, 2020
@diemol diemol transferred this issue from SeleniumHQ/selenium Oct 27, 2020
@omarmhaimdat
Copy link

I am still experiencing the same issue, and nothing works. The "maxSessions" variable is always set up at 2. Tested on firefox and chrome. I'm using the docker-compose-v3-full-grid.yml file.

@youssefqarri
Copy link

I am facing the same issue from my side.

@diemol
Copy link
Member

diemol commented Nov 27, 2020

I just fixed this in the main repository, and it will be released in the next couple of days. Please keep an eye on the releases for this repo.

AutomatedTester pushed a commit to SeleniumHQ/selenium that referenced this issue Nov 30, 2020
It is already in the code then the option is retrieved,
but additionally it means that it was taking precedence
over the value configured on the `config.toml`.

This fixes SeleniumHQ/docker-selenium#1128
@anandshende06051994
Copy link

Hey, any updates on this?

@diemol
Copy link
Member

diemol commented Dec 15, 2020

This was already fixed and released. Please check the most recent release.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants