Cache IWebElement before checking TagName is correct (#8904)

When creating a SelectElement we must first check the WrappedElement tag is select and throw a UnexpectedTagNameException otherwise.

Previously the WrappedElement was not cached so WebDriver API could be called up to three times: first to check the tag is not null, second to check it's value is select (ignoring case) and a third time as a parameter of UnexpectedTagNameException if any of the previous conditions failed.

Fixes #8899

Co-authored-by: elgato <[email protected]>

Author: elgatov

dotnet/src/support/UI/SelectElement.cs

@@ -44,9 +44,11 @@ public SelectElement(IWebElement element)
                 throw new ArgumentNullException("element", "element cannot be null");
             }
 
-            if (string.IsNullOrEmpty(element.TagName) || string.Compare(element.TagName, "select", StringComparison.OrdinalIgnoreCase) != 0)
+            string tagName = element.TagName;
+
+            if (string.IsNullOrEmpty(tagName) || string.Compare(tagName, "select", StringComparison.OrdinalIgnoreCase) != 0)
             {
-                throw new UnexpectedTagNameException("select", element.TagName);
+                throw new UnexpectedTagNameException("select", tagName);
             }
 
             this.element = element;