Skip to content

ProxyNodeCdp should also find Firefox CDP endpoints #9327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
shs96c opened this issue Mar 23, 2021 · 0 comments
Closed

ProxyNodeCdp should also find Firefox CDP endpoints #9327

shs96c opened this issue Mar 23, 2021 · 0 comments
Labels
B-grid Everything grid and server related C-java Java Bindings

Comments

@shs96c
Copy link
Member

shs96c commented Mar 23, 2021

🐛 Bug Report

The ProxyNodeCdp class only looks for Chrome and Edge CDP endpoints. It should also look for Firefox's endpoint.

To Reproduce

Read the code of the apply method.

Expected behavior

Firefox's CDP end point is reported.

Test script or set of commands reproducing this issue

N/A

Environment

OS: All
Browser: Firefox
Browser version: 88b1+
Browser Driver version: N/A
Language Bindings version: Java
Selenium Grid version (if applicable): 4.0
@shs96c shs96c added the B-grid Everything grid and server related label Mar 23, 2021
@ghost ghost added the A-needs-triaging A Selenium member will evaluate this soon! label Mar 23, 2021
@shs96c shs96c added C-java Java Bindings and removed A-needs-triaging A Selenium member will evaluate this soon! labels Mar 23, 2021
diemol added a commit that referenced this issue Apr 7, 2021
@diemol
[grid] Enhancing CdpEndpointFinder to get debuggerAddress URI
00b0b39 
This is part of the work needed for #9327
diemol added a commit that referenced this issue Apr 7, 2021
@diemol
[grid] Consolidating getReportedUri logic in CdpEndpointFinder
d9c0dd8 
This is work needed for #9327
@diemol diemol closed this as completed in 8012af9 Apr 7, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Sep 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
B-grid Everything grid and server related C-java Java Bindings
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shs96c