[py]: replace dead battery imghdr with filetype #14771
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Closes #14765
imghdr
module will be a dead battery starting with Python 3.13, replaced the tests to usefiletype
insteadTypes of changes
Checklist
PR Type
Bug fix, Enhancement
Description
imghdr
module withfiletype
for image type checking in various screenshot tests.filetype.guess
.filetype
as a dependency inrequirements.txt
and Bazel build configuration.cryptography
anddebugpy
versions in the lock file and removed unused dependencies.Changes walkthrough 📝
takes_screenshots_tests.py
Replace `imghdr` with `filetype` in screenshot tests
py/test/selenium/webdriver/common/takes_screenshots_tests.py
imghdr
withfiletype
for image type checking.filetype.guess
for MIME type validation.ff_takes_full_page_screenshots_tests.py
Update full page screenshot tests to use `filetype`
py/test/selenium/webdriver/firefox/ff_takes_full_page_screenshots_tests.py
imghdr
withfiletype
for full page screenshot tests.filetype.guess
for MIME type validation.remote_connection_tests.py
Use `filetype` for image type checking in remote tests
py/test/selenium/webdriver/remote/remote_connection_tests.py
imghdr
withfiletype
for remote connection tests.filetype.guess
for MIME type validation.BUILD.bazel
Add `filetype` to Bazel test dependencies
py/BUILD.bazel
filetype
as a new test dependency.requirements.txt
Add `filetype` to Python requirements
py/requirements.txt
filetype==1.2.0
to the requirements.requirements_lock.txt
Update locked dependencies and add `filetype`
py/requirements_lock.txt
cryptography
anddebugpy
versions.filetype
with specific hashes.jeepney
andsecretstorage
.