-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
[java][BiDi]: enable Edge tests for RemoteWebDriverBiDiTest #15412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f17dd08dd32998a310510f0abc44e5b484202a4d.
This reverts commit cc16e3f. oops
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
99003b0
to
c1fb42f
Compare
pujagani
approved these changes
Apr 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! @Delta456
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Motivation and Context
enable Edge tests for
RemoteWebDriverBiDiTest
Types of changes
Checklist
PR Type
Tests, Enhancement
Description
Enabled Edge browser support for
RemoteWebDriverBiDiTest
.Removed
@NotYetImplemented(EDGE)
annotations from relevant test methods.Updated Bazel configuration to include Edge in
firefox-chromium-only-large-tests
.Adjusted test suite naming and exclusions to reflect Edge support.
Changes walkthrough 📝
RemoteWebDriverBiDiTest.java
Enable Edge browser support in BiDi tests
java/test/org/openqa/selenium/grid/router/RemoteWebDriverBiDiTest.java
@NotYetImplemented(EDGE)
annotations from three test methods.listening, and URL navigation tests.
BUILD.bazel
Update Bazel configuration for Edge browser support
java/test/org/openqa/selenium/grid/router/BUILD.bazel
FIREFOX_CHROME_ONLY_LARGE_TESTS
toFIREFOX_CHROMIUM_ONLY_LARGE_TESTS
.firefox-chromium-only-large-tests
.medium-tests
to reflect the new test suite name.