[grid] Add registration secret to the New Session Queuer #9026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diemol
approved these changes
Jan 7, 2021
|
@pujagani, I just noticed this code smell, what do you think? |
diemol
approved these changes
Jan 7, 2021
|
SonarCloud Quality Gate failed. |
diemol
approved these changes
Jan 7, 2021
pujagani
added a commit
to pujagani/selenium
that referenced
this pull request
Jan 7, 2021
…9026) * [grid] Add registration secret to the New Session Queuer * [grid] Removed unused local variable from LocalNewSessionQueuer Co-authored-by: Diego Molina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Add registration secret to the New Session Queuer endpoints.
Motivation and Context
The Grid uses registration secret for endpoints that change the state of the Grid. Hence, for New Session Queuer endpoints that effect the Grid state, registration secret filter is added.
Types of changes
Checklist