Skip to content

[grid] Upgrade OpenTelemetry to 0.12.0 #9029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 7, 2021

Conversation

pujagani
Copy link
Contributor

@pujagani pujagani commented Jan 7, 2021

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Upgrade OpenTelemetry to 0.12.0.

Motivation and Context

The newer versions of OpenTelemetry do not maintain backward compatibility and introduce new APIs. To protect from such changes, Selenium has a wrapper around OpenTelemetry. The wrapper is updated to match the new APIs, adjust imports and update the deprecated APIs.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@pujagani pujagani force-pushed the opentelemetry-upgrade branch from 7781a5e to a4d0e2d Compare January 7, 2021 06:55
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 7, 2021

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @pujagani!

@diemol diemol merged commit dd5d7a0 into SeleniumHQ:trunk Jan 7, 2021
pujagani added a commit to pujagani/selenium that referenced this pull request Jan 7, 2021
* [grid] Upgrade OpenTelemetry to 0.11.0

* [grid] Upgrade OpenTelemetry to 0.12.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants