-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
Add attribute_to_be_include method to expected_conditions when the at… #9200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
AutomatedTester
merged 12 commits into
SeleniumHQ:trunk
from
sunnyyukaige:my-feature-branch
Mar 2, 2021
Merged
Add attribute_to_be_include method to expected_conditions when the at… #9200
AutomatedTester
merged 12 commits into
SeleniumHQ:trunk
from
sunnyyukaige:my-feature-branch
Mar 2, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@AutomatedTester the test relative of my change all pass, look forward for your review, many many thx 😋 |
…tribute given is include the element's attributes
… of expected_conditions when the attribute given is include the element's attributes
072df53
to
b457c76
Compare
AutomatedTester
approved these changes
Mar 2, 2021
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tribute given is include the element's attributes
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Add attribute_to_be_include method to expected_conditions when the attribute given is include the element's attributes
Motivation and Context
Can use attribute_to_be_include method of expected_conditions when the attribute given is include the element's attributes
Types of changes
Checklist