Skip to content

[java] Add null check before returning isDisplayed value #9299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 18, 2021
Merged

[java] Add null check before returning isDisplayed value #9299

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fc27a6c
[java] Add null check before returning isDisplayed value
pujagani Mar 18, 2021
a86be8a
Update java/client/src/org/openqa/selenium/remote/RemoteWebElement.java
diemol Mar 18, 2021
82c9810
Merge branch 'trunk' into add-null-check
diemol Mar 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions java/client/src/org/openqa/selenium/remote/RemoteWebElement.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,9 @@ public boolean isDisplayed() {
Object value = execute(DriverCommand.IS_ELEMENT_DISPLAYED(id))
.getValue();
try {
if (value == null) {
return false;
}
return (Boolean) value;
} catch (ClassCastException ex) {
throw new WebDriverException("Returned value cannot be converted to Boolean: " + value, ex);
Expand Down