Skip to content

Add the debuggerAddress option to chromium.js #9561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

bwalderman
Copy link
Contributor

@bwalderman bwalderman commented Jun 10, 2021

Description

Adding a setter for Chromium's debuggerAddress capability. This is available in other language bindings but was missing from the JS bindings.

Motivation and Context

Chromium-based drivers provide the debuggerAddress option to let the user attach to an already-running browser instance at the specified address instead of launching a new one. One example where this is useful is certain WebView2 (WV2) scenarios. Users may want to test the web portion of an app that embeds WV2, but need to launch the app outside WebDriver first and drill through some native UI in order to activate the WV2 they are trying to test.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • [ X] I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@AutomatedTester
Copy link
Member

Thanks for the PR. Could you give a bit more context about why this is needed? Currently, we get the debugger address from the capabilities returned and allow the driver to figure out where to put it.

@bwalderman
Copy link
Contributor Author

Thanks, I've updated the motivation in the PR description.

@harsha509 harsha509 added the C-nodejs JavaScript Bindings label Jul 4, 2021
@AutomatedTester AutomatedTester merged commit 2c8c4ff into SeleniumHQ:trunk Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-nodejs JavaScript Bindings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants