Skip to content

Update deps #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 4, 2016
Merged

Update deps #2

merged 2 commits into from
Aug 4, 2016

Conversation

Layoric
Copy link
Member

@Layoric Layoric commented Aug 4, 2016

@mythz I've updated deps and gulpfile to match the more recently templates.

I still can't compile due to react-ga typings missing a set function. Are you using another typings locally for react-ga? The rest looks fine.

Layoric added 2 commits August 4, 2016 19:02
ReactGA typings seem to be invalid. Missing `set` function.
@mythz mythz merged commit 96620ce into master Aug 4, 2016
@mythz
Copy link
Member

mythz commented Aug 4, 2016

thx, I may have manually edited the react-ga index.d.ts, here's what I have now:

// Generated by typings
// Source: https://raw.githubusercontent.com/DefinitelyTyped/DefinitelyTyped/1751c28d19510f44b61abad6e219b2b82e0cba30/react-ga/react-ga.d.ts
declare namespace __reactGA {
    export interface EventArgs {
        category: string;
        action: string;
        label?: string;
        value?: number;
        nonInteraction?: boolean;
    }

    export interface InitializeOptions {
        debug?: boolean;
    }

    export function initialize(trackingCode: string, options?: InitializeOptions): void;
    export function pageview(path: string): void;
    export function modalview(name: string): void;
    export function event(args: EventArgs): void;
    export function set(fieldsObject: any): void;
}

declare module 'react-ga' {
    export = __reactGA;
}

@Layoric
Copy link
Member Author

Layoric commented Aug 4, 2016

Ahh ok cool, thought so. Found another if that helps for other methods.

react-ga/react-ga@f6e4abc?diff=unified

@mythz
Copy link
Member

mythz commented Aug 4, 2016

cool, looks more complete, weird it's a green PR outstanding from May 8.

@Layoric Layoric deleted the update-deps branch August 10, 2016 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants