Skip to content

Addressing issue of error_threshold_timeout_enabled opening too aggressively #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Addressing issue of error_threshold_timeout_enabled opening too aggressively #652

wants to merge 2 commits into from

Conversation

abishanan-shopify
Copy link
Contributor

Following up on Issue: #634

To-do:

  • Add test case to validate the consecutiveness property is satisfied
  • If not satisfied, implement solution that ensures consecutive property is met
  • Update PR description with Changes, Implementation and Rationale

@abishanan-shopify abishanan-shopify force-pushed the error-threshold-timeout-testing branch 5 times, most recently from 285020a to 23e24e4 Compare June 25, 2025 20:56
@abishanan-shopify abishanan-shopify self-assigned this Jun 25, 2025
@abishanan-shopify abishanan-shopify force-pushed the error-threshold-timeout-testing branch 5 times, most recently from 551f0a9 to 4010dce Compare June 26, 2025 16:45
@abishanan-shopify
add check to clear errors on first success if
86bb16d 
error_threshold_timeout_enabled false
@abishanan-shopify abishanan-shopify force-pushed the error-threshold-timeout-testing branch from 4010dce to 86bb16d Compare June 26, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@abishanan-shopify abishanan-shopify

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@abishanan-shopify