This repository was archived by the owner on Jun 2, 2025. It is now read-only.
[cmake] make python stubs depend on .pyc file compilation & sync submodule #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisv
reviewed
May 15, 2024
| @@ -70,8 +70,10 @@ endforeach() | |||
|
|
|||
| # Generate stubs | |||
| if(GENERATE_PYTHON_STUBS) | |||
| python_build_get_target(python_build_target_name) | |||
| load_stubgen() | |||
| generate_stubs( | |||
There was a problem hiding this comment.
Add a comment to explain generate_stubs dependencies.
I copy/paste the comment from pinocchio as an example :
# Set PYWRAP and PROJECT_NAME as stubs dependencies.
# PROJECT_NAME is mandatory (even if it's a PYWRAP dependency)
# to find PROJECT_NAME name DLL on windows.
|
windows isn't real it can't hurt us |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.