Skip to content

added mimetype command line option #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 17, 2023
Merged

added mimetype command line option #20

merged 2 commits into from
Feb 17, 2023

Conversation

dave3d
Copy link
Member

@dave3d dave3d commented Feb 17, 2023

No description provided.

@dave3d dave3d requested a review from zivy February 17, 2023 20:20
zivy
zivy approved these changes Feb 17, 2023
View reviewed changes
Copy link
Member

@zivy zivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Question is the mime type for markdown or rst "text/plain"? Possibly add some example types to the help message for the --type flag.

@dave3d dave3d merged commit c7cef28 into SimpleITK:main Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zivy zivy zivy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dave3d @zivy