Reduce accepted cyclomatic complexity from 32 to 25 #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfr
reviewed
Jul 11, 2023
pyproject.toml
Outdated
| @@ -33,4 +33,4 @@ local_scheme = "dirty-tag" | |||
| [tool.flake8] | |||
| max-line-length = 88 | |||
| ignore = ['E203', 'W503'] | |||
| max_complexity = 32 | |||
| # max_complexity = 32 | |||
There was a problem hiding this comment.
Suggested change
| # max_complexity = 32 | |
| max_complexity = 25 |
|
Suggested commit title: |
|
I will revisit the integration of |
dave3d
approved these changes
Jul 11, 2023
blowekamp
force-pushed
the
update_complexity
branch
from
d05c16c to
e75ea79
Compare
I'm not sure what appears incorrect. I just set the value to 24, which triggered: as expected. I will update to 25, and it is expected to pass. |
blowekamp
changed the title
blowekamp
force-pushed
the
update_complexity
branch
from
e75ea79 to
43591f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.