Skip to content

ENH: Identify error word as valid if additional check succeeds #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

jcfr
Copy link
Contributor

@jcfr jcfr commented Jul 11, 2023

To avoid performing unneeded additional spell check by removing all prefixes, this pull request set the valid internal variable to True and exit the loop if the error word without a given prefix is valid.

@jcfr jcfr mentioned this pull request Jul 11, 2023
@jcfr
Copy link
Contributor Author

jcfr commented Jul 11, 2023

@dave3d This is ready for review and integration 🙏

@dave3d dave3d merged commit f526610 into SimpleITK:main Jul 11, 2023
@jcfr jcfr deleted the optimize-error-checking branch July 11, 2023 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants