Feat: Show own marker on top

[Kemmisch]

there has to be some better way to do this
tried gltranslate by positive z in d245eac
but didn't work
also tried a large variety of other stuff with gl translate but wouldn't work either
changing the order that they got passed in does work

note: pre/post draw function - did try removing the enable/disable depth, but didn't do anything
.toList().sortedBy {} probably not that performant

[gemini-code-assist]

Hello @Kemmisch, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request introduces a new feature to the Catlas dungeon map in SkytilsMod that allows players to always display their own player marker on top of other player markers. This is achieved by adding a configuration option and modifying the rendering order of player heads on the map.

Highlights

• New Configuration Option: A new switch alwaysShowOwnPlayerOnTop is added to the Catlas configuration, allowing players to toggle the feature on or off.
• Modified Rendering Order: The rendering order of player heads is modified to prioritize the player's own head marker when the configuration option is enabled. This is done by sorting the team list before rendering.
• Localization: A new localization string is added for the new configuration option.

Changelog

• src/main/kotlin/gg/skytils/skytilsmod/features/impl/dungeons/catlas/core/CatlasConfig.kt
  • Added a new configuration option alwaysShowOwnPlayerOnTop to control whether the player's own marker is always shown on top.
  • The new configuration option is a switch with a description, category, and i18n names.
• src/main/kotlin/gg/skytils/skytilsmod/features/impl/dungeons/catlas/core/CatlasElement.kt
  • Modified the renderPlayerHeads function to sort the team list based on the alwaysShowOwnPlayerOnTop configuration option.
  • The sorting logic prioritizes the player's own marker when the option is enabled.
• src/main/resources/assets/catlas/lang/en_US.lang
  • Added a new localization string for the alwaysShowOwnPlayerOnTop configuration option.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

---

Upon the map, a head so grand,
Yours always first, across the land.
A simple tweak,
A visual peak,
Your presence known, close at hand.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request introduces a new configuration option to always show the player's own marker on top of the dungeon map. This feature enhances user experience by providing better visibility of the player's location. The implementation involves adding a configuration switch and modifying the player head rendering logic. Overall, the changes are well-structured and address the intended functionality.

Summary of Findings

• Performance Consideration: The use of toList().sortedBy in renderPlayerHeads might introduce performance overhead, especially with a large number of players. Consider alternative approaches for sorting that are more efficient.

Merge Readiness

The pull request is well-structured and introduces a useful feature. However, the potential performance impact of the sorting method in renderPlayerHeads should be addressed before merging. I am unable to directly approve this pull request, and recommend that others review and approve this code before merging. Addressing the performance concern would improve the overall quality of the code and ensure a smoother user experience.