Skip to content

docs: Use docker compose profiles to select ingest gateway to run #1448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

rjmunro
Copy link

@rjmunro rjmunro commented May 9, 2025

About the Contributor

This work was done on behalf of SuperflyTV

Type of Contribution

This is a Documentation improvement

Current Behaviour

There were complicated instructions about uncommenting sections of the example docker compose file.

New Behaviour

Profiles have been added to the example docker compose file and

Testing

  • I have added one or more unit tests for this PR
  • I have updated the relevant unit tests
  • No unit test changes are needed for this PR

Affected areas

Suggested docker-compose configuration.

Time Frame

  • Not urgent, but we would like to get this merged into the in-development release.

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

Copy link

codecov bot commented May 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.91%. Comparing base (46369a4) to head (9cd7827).
Report is 31 commits behind head on release53.

Additional details and impacted files
@@              Coverage Diff              @@
##           release53    #1448      +/-   ##
=============================================
- Coverage      54.12%   53.91%   -0.22%     
=============================================
  Files            404      405       +1     
  Lines          73586    73640      +54     
  Branches        5376     5365      -11     
=============================================
- Hits           39832    39706     -126     
- Misses         33604    33784     +180     
  Partials         150      150              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rjmunro rjmunro marked this pull request as ready for review May 12, 2025 12:30
@rjmunro rjmunro requested a review from a team as a code owner May 12, 2025 12:30
@nytamin nytamin added Contribution from SuperFly.tv Contributions sponsored by SuperFly.tv Contribution External contribution labels May 16, 2025
@Julusian Julusian requested a review from a team as a code owner June 13, 2025 08:01
@Julusian Julusian merged commit 3151572 into Sofie-Automation:release53 Jun 13, 2025
31 checks passed
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution from SuperFly.tv Contributions sponsored by SuperFly.tv Contribution External contribution
Development

Successfully merging this pull request may close these issues.

4 participants