Fix: Rundown memory leak #1477
Draft
Fix: Rundown memory leak #1477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Julusian
added
Contribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the Contributor
This PR is made on behalf of BBC
Type of Contribution
This is a fix
Current Behavior
Currently in Release 52 and 53 a lot of segments (and other nodes) are detached, so no longer in DOM but still in memory.
New Behavior
A service is running in the RundownView that clean up lost elements/nodes.
This I a hack that solves the memory leak, but doesn't solve the root cause.
Testing
Affected areas
This is affecting the UI's memory usage.
Time Frame
This bug fix is critical for BBC.
Status