Skip to content

Avoid PHP 8.4 deprecation "Implicitly marking parameter as nullable" #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BA-JBI
Copy link

@BA-JBI BA-JBI commented Apr 23, 2025

Since PHP 8.4 Implicitly marking parameter as nullable is deprecated.
This is easy to fix using the explicit nullable type introduced in PHP 7.1

https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated

…s deprecated, the explicit nullable type must be used"
@gilles-g
Copy link
Contributor

Hi @BA-JBI ,
Thank you for this PR!

But it would be awesome to use another tool to update to PHP 8.4. We have an outdated file rector here https://github.com/SpiriitLabs/form-filter-bundle/blob/master/rector.php

Maybe I/you could have a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants