Enable Client Completions for non-Sponge/Brig commands. #3107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dualspiral
force-pushed
the
api8/clientcompletion
branch
2 times, most recently
from
17b7e39 to
c8e87e6
Compare
* Split raw commands from the parameterized commands registrar completely to support this change * Fix /sponge which not working with namespaced commands
dualspiral
force-pushed
the
api8/clientcompletion
branch
from
c8e87e6 to
e319aa1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SpongeAPI | SpongeCommon
This should be the last major change for commands, I think this is the last thing that needed doing.
There is a lot going on here but most of this is for enabling client completions for non-Sponge and non-Brig commands, as well as fixing a few issues. Command tab completion now works for non-Sponge commands, the way that third parties tell Sponge about the structure of their commands is now a little saner.
Also,
/sponge whichnow works properly as I treat the commands are resource keys on the client - fixing namespaced commands coming up red.I also moved the commands from the test plugin into its own plugin.