Skip to content

Migrate build scripts to Kotlin-DSL #1980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 12, 2019
Merged

Migrate build scripts to Kotlin-DSL #1980

merged 5 commits into from
Sep 12, 2019

Conversation

gabizou
Copy link
Member

@gabizou gabizou commented Mar 8, 2019

SpongeGradle | SpongeAPI | SpongeCommon | SpongeVanilla | SpongeForge

This is a working PR with the development lock step with SpongeGradle. While this technically is compatible with Gradle 4.10.3, I've elected to use the latest Gradle 5.6.2 (as of current writing) to take advantage of the improved Kotlin-DSL since those versions, and configuration avoidance throughout the build process.

Some changes:

  • Constants are just constants in files
  • Things that should've been made properties are now properties and/or functions in SpongeGradle or in the gradle.properties of their respective projects
  • Updated to use appropriate Gradle ideologies with configuration avoidance (lazy evaluation)
  • Reduced the overall build file size and using as much handling with the gradle plugins to configure most things we've otherwise duplicated and/or scripted with other scripts.

@gabizou gabizou requested a review from Aaron1011 March 8, 2019 05:12
@gabizou gabizou force-pushed the build/kotlin-dsl branch from 685329e to 3420149 Compare March 9, 2019 05:01
Signed-off-by: Gabriel Harris-Rouquette <[email protected]>
Signed-off-by: Gabriel Harris-Rouquette <[email protected]>
}

dependencies {
implementation("net.minecrell.licenser:net.minecrell.licenser.gradle.plugin:0.4.1")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason these can't be used in the plugins block above?

Signed-off-by: Gabriel Harris-Rouquette <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants