Make TradeOfferGenerator extend a BiFunction instead to handle 1.14 implementation. #2070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ffer> instead of a Function<Random, TradeOffer>. This is to compensate for 1.14 now requiring a Merchant to call VillagerTrades$ITrade#getOffer(Entity, Random) since some Villagers such as the Cartogrpher Villager require access to the world from the entity to find a Woodland Mansion or a Monument.
|
Is this used as a bifunction so often that it must implement |
gabizou
added a commit
that referenced
this pull request
Dec 18, 2019
Signed-off-by: Gabriel Harris-Rouquette <[email protected]>
This was referenced Jan 9, 2022
build: Update dependency org.spongepowered:spongeapi to v8
IntellectualSites/FastAsyncWorldEdit#1531
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to compensate for 1.14 now requiring a Merchant to call
VillagerTrades$ITrade#getOffer(Entity, Random)since some Villagers such as the Cartographer Villager require access to the world from the entity to find a Woodland Mansion or a Monument.This here is part of the changes with SpongePowered/Sponge#2434